Add ExtProc Logging Bits for Immediate Response, Continue and Replace #41602
+147
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in FilterState Signed-off-by: Melissa Ginaldi <[email protected]>
Signed-off-by: Melissa Ginaldi <[email protected]>
…resp-contreplace Signed-off-by: Melissa Ginaldi <[email protected]>
Signed-off-by: Melissa Ginaldi <[email protected]>
Signed-off-by: Melissa Ginaldi <[email protected]>
melginaldi
requested review from
mattklein123,
tyxia and
yanavlasov
as code owners
|
/assign @yanjunxiang-google |
…resp-contreplace Signed-off-by: Melissa Ginaldi <[email protected]>
|
/assign @tyxia |
…resp-contreplace Signed-off-by: Melissa Ginaldi <[email protected]>
Signed-off-by: Melissa Ginaldi <[email protected]>
…resp-contreplace Signed-off-by: Melissa Ginaldi <[email protected]>
…resp-contreplace Signed-off-by: Melissa Ginaldi <[email protected]>
tyxia
reviewed
Oct 27, 2025
There was a problem hiding this comment.
LGTM in general. Thanks for contribution!
I will let @yanjunxiang-google review it as well
| void onFinishProcessorCall(Grpc::Status::GrpcStatus call_status, | ||
| CallbackState next_state = CallbackState::Idle); | ||
| CallbackState next_state = CallbackState::Idle, | ||
| bool continue_and_replace = false); |
There was a problem hiding this comment.
nit: given this function is only called in two places, we can just specify continue_and_replace on the caller site, instead of having default arg
| // Test the ability of the filter to completely replace a request message with a new | ||
| // request message. | ||
| TEST_P(ExtProcIntegrationTest, ExtProcLoggingInfoContinueAndReplace) { | ||
| auto access_log_path = TestEnvironment::temporaryPath(TestUtility::uniqueFilename()); |
There was a problem hiding this comment.
we probably should think about sharing the common code between tests. e.g., ExtProcLoggingInfoGRPCTimeout, to improve the code maintenance.
ext_proc_integration_test has grown significantly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Add bits to the FilterState in ExtProcLoggingInfo for when an immediate response is sent and when continue_and_replace is used.
Additional Description: These bits will be useful for internal debugging. Continue and Replace is only relevant for request and response headers.
Risk Level: Low
Testing: Unit Integration tests
Docs Changes: N/A
Release Notes: Add new bits into ExtProcLoggingInfo for Immediate Response occurrence and ContinueAndReplace.
Platform Specific Features: N/A
/assign @yanjunxiang-google